Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property

From: Sasha Levin
Date: Mon Jun 22 2020 - 08:31:22 EST


On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote:
On Sun, Jun 21, 2020 at 07:33:52PM -0400, Sasha Levin wrote:
On Thu, Jun 18, 2020 at 03:39:30PM +0100, Mark Brown wrote:
> On Thu, Jun 18, 2020 at 10:30:46AM -0400, Sasha Levin wrote:
> > On Thu, Jun 18, 2020 at 12:00:23PM +0100, Mark Brown wrote:

> > > This is a new feature not a bugfix.

> > I saw this patch more as a hardware quirk.

> Pretty much any DT property is a hardware quirk :(

Which is why we're taking most of them :)

That's concerning - please don't do this. It's not what stable is
expected to be and there's no guarantee that you're getting all the
changes required to actually make things work.

How come? This is one of the things stable rules explicitly call for:
"New device IDs and quirks are also accepted".

If we're missing anything, the solution is to make sure we stop missing
it rather than not take anything to begin with :)

--
Thanks,
Sasha