Re: [PATCH v4 1/2] thermal: add support for the MCU controlled FAN on Khadas boards

[Amit Kucheria]

On Thu, Jun 18, 2020 at 9:58 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> On Thu, 18 Jun 2020, Neil Armstrong wrote:
>
> > The new Khadas VIM2 and VIM3 boards controls the cooling fan via the
> > on-board microcontroller.
> >
> > This implements the FAN control as thermal devices and as cell of the Khadas
> > MCU MFD driver.
> >
> > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> > Reviewed-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx>
>
> Is this an Ack?

Acked-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx>

> If so, do you require a pull-request?

I'll let Daniel comment about the PR but AFAICT, this can get merged
through the MFD tree.


> > ---
> > Hi Lee,
> >
> > Could you apply this patch via the MFD tree since it depends on
> > the linux/mfd/khadas-mcu.h header ?
> >
> > This patch is unchanged from the v3 serie.
> >
> > Thanks,
> > Neil
> >
> >  drivers/thermal/Kconfig          |  11 ++
> >  drivers/thermal/Makefile         |   1 +
> >  drivers/thermal/khadas_mcu_fan.c | 174 +++++++++++++++++++++++++++++++
> >  3 files changed, 186 insertions(+)
> >  create mode 100644 drivers/thermal/khadas_mcu_fan.c
>
> --
> Lee Jones [æçæ]
> Senior Technical Lead - Developer Services
> Linaro.org â Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog