Re: [PATCH] proc: Avoid a thundering herd of threads freeing proc dentries

From: Eric W. Biederman
Date: Fri Jun 19 2020 - 13:29:05 EST


Junxiao Bi <junxiao.bi@xxxxxxxxxx> writes:

> Hi Eric,
>
> The patch didn't improve lock contention.

Which raises the question where is the lock contention coming from.

Especially with my first variant. Only the last thread to be reaped
would free up anything in the cache.

Can you comment out the call to proc_flush_pid entirely?

That will rule out the proc_flush_pid in d_invalidate entirely.

The only candidate I can think of d_invalidate aka (proc_flush_pid) vs ps.

Eric