Re: [PATCH 2/2] sched/uclamp: Protect uclamp fast path code with static key

From: Steven Rostedt
Date: Fri Jun 19 2020 - 09:23:15 EST


On Fri, 19 Jun 2020 13:51:48 +0100
Qais Yousef <qais.yousef@xxxxxxx> wrote:

> > On 18/06/20 20:55, Qais Yousef wrote:
> > > There is a report that when uclamp is enabled, a netperf UDP test
> > > regresses compared to a kernel compiled without uclamp.
> > >
> > > https://lore.kernel.org/lkml/20200529100806.GA3070@xxxxxxx/
> > >
> >
> > ISTR the perennial form for those is: https://lkml.kernel.org/r/<message-id>
>
> The link is correct permalinnk from lore and contains the message-id as Peter
> likes and he has accepted this form before.
>
> If you look closely you'll see that what you suggest is just moving 'lkml' to
> replace lore in the dns name and put an /r/. I don't see a need to enforce one
> form over the other as the one I used is much easier to get.

The two produce the same result, and I personally have used both. I'm
starting to move over to lore over lkml, as that seems to be becoming
the more popular form.

>
> If Peter really insists I'll be happy to change.

But I agree, if Peter is insistent on lkml over lore, then it really
doesn't make a difference to switch it. As I said, they are identical
in what they produce.

-- Steve