Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE

From: Bastien Nocera
Date: Fri Jun 19 2020 - 06:50:56 EST


On Thu, 2020-06-18 at 11:42 +0200, Greg Kroah-Hartman wrote:
> The USB core has a quirk flag to ignore specific endpoints, so rename
> it
> to be more obvious what this quirk does.
>
> Cc: Johan Hovold <johan@xxxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Richard Dodd <richard.o.dodd@xxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> Cc: Jonathan Cox <jonathan@xxxxxxxxx>
> Cc: Bastien Nocera <hadess@xxxxxxxxxx>
> Cc: "ThiÃbaud Weksteen" <tweek@xxxxxxxxxx>
> Cc: Nishad Kamdar <nishadkamdar@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

If the driver API change below is agreeable, you can add my:
Reviewed-by: Bastien Nocera <hadess@xxxxxxxxxx>

Good job.

<snip>
> diff --git a/include/linux/usb/quirks.h b/include/linux/usb/quirks.h
> index 22c1f579afe3..5e4c497f54d6 100644
> --- a/include/linux/usb/quirks.h
> +++ b/include/linux/usb/quirks.h
> @@ -69,7 +69,7 @@
> /* Hub needs extra delay after resetting its port. */
> #define USB_QUIRK_HUB_SLOW_RESET BIT(14)
>
> -/* device has blacklisted endpoints */
> -#define USB_QUIRK_ENDPOINT_BLACKLIST BIT(15)
> +/* device has endpoints that should be ignored */
> +#define USB_QUIRK_ENDPOINT_IGNORE BIT(15)
>
> #endif /* __LINUX_USB_QUIRKS_H */