Re: [PATCH] RISC-V: Acquire mmap lock before invoking walk_page_range

From: Atish Patra
Date: Thu Jun 18 2020 - 21:34:27 EST


On Wed, Jun 17, 2020 at 7:29 PM Zong Li <zong.li@xxxxxxxxxx> wrote:
>
> On Thu, Jun 18, 2020 at 8:01 AM Michel Lespinasse <walken@xxxxxxxxxx> wrote:
> >
> > On Wed, Jun 17, 2020 at 1:38 PM Atish Patra <atish.patra@xxxxxxx> wrote:
> > > As per walk_page_range documentation, mmap lock should be acquired by the
> > > caller before invoking walk_page_range. mmap_assert_locked gets triggered
> > > without that. The details can be found here.
> > >
> > > http://lists.infradead.org/pipermail/linux-riscv/2020-June/010335.html
> > >
> > > Fixes: 395a21ff859c(riscv: add ARCH_HAS_SET_DIRECT_MAP support)
> > > Signed-off-by: Atish Patra <atish.patra@xxxxxxx>
> >
> > Thanks for the fix.
> >
> > Reviewed-by: Michel Lespinasse <walken@xxxxxxxxxx>
>
> It also looks good to me. Thanks for the fix.
>
> Reviewed-by: Zong Li <zong.li@xxxxxxxxxx>
>

Hi Palmer,
Can you include this one in rc2 PR as well ?
Anybody who gets this issue with their rootfs can't use rc1 without
turning off DEBUG_VM.

--
Regards,
Atish