Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

From: Horia GeantÄ
Date: Thu Jun 18 2020 - 06:41:21 EST


On 6/18/2020 10:58 AM, Herbert Xu wrote:
> On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> The variable ret is being assigned a value that is never read, the
>> error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning
>> ret with -ENOMEM is redundamt.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> ---
>> drivers/crypto/caam/caamalg_qi2.c | 2 --
>> 1 file changed, 2 deletions(-)
>
> Patch applied. Thanks.
>
Unfortunately I missed this patch, and it doesn't look correct.

Do I need to send a revert?

Thanks,
Horia