RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

[Avri Altman]

> 
> This is a patch for the HPB module.
> The HPB module queries UFS for device information during initialization.
> We added the export symbol to two functions in ufshcd.c to initialize
> the HPB module.
> 
> The HPB module can be loaded or built-in as needed.
> The mininum size of the memory pool used in the HPB module is
Typo minimum

> implemented
> as a module parameter, so that it can be configurable by the user.
> 
> To gurantee a minimum memory pool size of 4MB:
> $ insmod ufshpb.ko ufshpb_host_map_kbytes=4096
You are going through a lot of troubles to make it a loadable module.
What are, in your opinion, the pros and cons of this design decision?