Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed

From: Greg KH
Date: Wed Jun 17 2020 - 01:58:59 EST


On Wed, Jun 17, 2020 at 09:27:47AM +1000, Stephen Rothwell wrote:
> This is in preparation for removing the include of major.h where it is
> not needed.
>
> These files were found using
>
> grep -E -L '[<"](uapi/)?linux/major\.h' $(git grep -l -w -f /tmp/xx)
>
> where /tmp/xx contains all the symbols defined in major.h. There were
> a couple of files in that list that did not need the include since the
> references are in comments.
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

Any reason this had an RFC, but patch 2/2 did not?

They look good to me, I will be glad to take these, but do you still
want reviews from others for this? It seems simple enough to me...

thanks,

greg k-h