Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in rpi_firmware_print_firmware_revision()

From: Sergey Senozhatsky
Date: Tue Jun 16 2020 - 21:08:27 EST


On (20/06/16 18:42), Nicolas Saenz Julienne wrote:
> On Tue, 2020-06-16 at 19:31 +0300, Andy Shevchenko wrote:
> > time64_t is 64-bit width type, we are not supposed to supply lesser ones
> > as in the case of rpi_firmware_print_firmware_revision() after the commit
> > 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT"). Use temporary variable
> > of time64_t type to correctly handle lesser types.
> >
> > Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
[..]
>
> If this doesn't fit the printk tree I don't mind taking it trough the rpi soc
> tree.

I think, for this patch, SoC tree might be a better fit
than printk tree, thanks.

-ss