Re: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages"

From: Andrew Morton
Date: Tue Jun 16 2020 - 14:36:06 EST


On Tue, 16 Jun 2020 15:16:43 +0900 js1304@xxxxxxxxx wrote:

> Subject: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages"

I'm having trouble locating such a patch.

> Non-file-lru page could also be activated in mark_page_accessed()
> and we need to count this activation for nonresident_age.
>
> Note that it's better for this patch to be squashed into the patch
> "mm: workingset: age nonresident information alongside anonymous pages".
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> ---
> mm/swap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/swap.c b/mm/swap.c
> index 667133d..c5d5114 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -443,8 +443,7 @@ void mark_page_accessed(struct page *page)
> else
> __lru_cache_activate_page(page);
> ClearPageReferenced(page);
> - if (page_is_file_lru(page))
> - workingset_activation(page);
> + workingset_activation(page);
> }
> if (page_is_idle(page))
> clear_page_idle(page);

AFAICT this patch Fixes: a528910e12ec7ee ("mm: thrash detection-based file
cache sizing")?