Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

From: Pierre Morel
Date: Tue Jun 16 2020 - 09:36:52 EST




On 2020-06-16 14:20, Cornelia Huck wrote:
On Tue, 16 Jun 2020 12:52:50 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:

On 2020-06-16 11:52, Halil Pasic wrote:
On Mon, 15 Jun 2020 14:39:24 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:

@@ -162,6 +163,11 @@ bool force_dma_unencrypted(struct device *dev)
return is_prot_virt_guest();
}
+int arch_needs_iommu_platform(struct virtio_device *dev)

Maybe prefixing the name with virtio_ would help provide the
proper context.

The virtio_dev makes it obvious and from the virtio side it should be
obvious that the arch is responsible for this.

However if nobody has something against I change it.

arch_needs_virtio_iommu_platform()?

fine with me

--
Pierre Morel
IBM Lab Boeblingen