Re: [Patch v1] i40e: limit the msix vectors based on housekeeping CPUs

From: Christoph Hellwig
Date: Tue Jun 16 2020 - 04:03:12 EST


On Mon, Jun 15, 2020 at 04:21:25PM -0400, Nitesh Narayan Lal wrote:
> + hk_flags = HK_FLAG_DOMAIN | HK_FLAG_WQ;
> + mask = housekeeping_cpumask(hk_flags);
> + cpus = cpumask_weight(mask);

Code like this has no business inside a driver. Please provide a
proper core API for it instead. Also please wire up
pci_alloc_irq_vectors* to use this API as well.