Re: [PATCH v4] iommu/vt-d: Don't apply gfx quirks to untrusted devices

From: Mika Westerberg
Date: Wed Jun 03 2020 - 10:54:56 EST


On Wed, Jun 03, 2020 at 06:03:17AM -0700, Rajat Jain wrote:
> Currently, an external malicious PCI device can masquerade the VID:PID
> of faulty gfx devices, and thus apply iommu quirks to effectively
> disable the IOMMU restrictions for itself.
>
> Thus we need to ensure that the device we are applying quirks to, is
> indeed an internal trusted device.
>
> Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx>
> Acked-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Reviewed-by: Ashok Raj <ashok.raj@xxxxxxxxx>

Looks good now, thanks!

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>