Re: [v2] afs: Fix memory leak in afs_put_sysnames()

From: Markus Elfring
Date: Tue Jun 02 2020 - 01:51:28 EST


>> * Is freeing and releasing an item a duplicate operation anyhow?
>
> You're missing the point. afs_put_sysnames() does release the things the
> object points to (ie. the content),

It is possible to distinguish the release of system resources for further items.


> but not the object itself.

How does this view fit to the proposed addition "kfree(sysnames);"?
https://lore.kernel.org/linux-fsdevel/20200602013045.321855-1-chengzhihao1@xxxxxxxxxx/
https://lore.kernel.org/patchwork/patch/1251323/

Regards,
Markus