Re: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

From: dinghao . liu
Date: Sun May 31 2020 - 04:23:40 EST


>
> > It's the same when gm20b_clk_new() returns from elsewhere following this call.
>
> I suggest to reconsider the interpretation of the software situation once more.
> Can it be that the allocated clock object should be kept usable even after
> a successful return from this function?
>

It's possible that we expect an usable clk pointer, though I could not find
the exact usage yet. For security, I will release this pointer only on error
paths in this function.

>
> Would you like to add the tag âFixesâ to the commit message?
>

Thank you for your advice! I will add this tag in the next version of patch.

Regards,
Dinghao