Re: [PATCH 06/19] perf ftrace: add support for trace option sleep-time

From: Namhyung Kim
Date: Sun May 31 2020 - 01:57:30 EST


On Thu, May 21, 2020 at 6:01 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> Em Sun, May 10, 2020 at 11:06:15PM +0800, Changbin Du escreveu:
> > This adds an option '--nosleep-time' which allow us only to measure
> > on-CPU time. This option is function_graph tracer only.
>
> This seems, for now, very specific to the function_graph tracer, so
> perhaps we should have a:
>
> --function_graph_opts nosleep-time,other,another,etc
>
> ?

Agreed. Also I don't want to add an option in a negative form
as it's confusing. Actually, our option parser can recognize
--no-xxx form automatically so adding a positive option (--xxx)
can handle that too.

Thanks
Namhyung