Re: [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

From: Rob Herring
Date: Fri May 29 2020 - 15:04:04 EST


On Wed, May 27, 2020 at 11:49:33AM -0500, Dan Murphy wrote:
> Add the internal delay values into the header and update the binding
> with the internal delay properties.
>
> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> ---
> .../devicetree/bindings/net/ti,dp83869.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83869.yaml b/Documentation/devicetree/bindings/net/ti,dp83869.yaml
> index 5b69ef03bbf7..2971dd3fc039 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83869.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83869.yaml
> @@ -64,6 +64,20 @@ properties:
> Operational mode for the PHY. If this is not set then the operational
> mode is set by the straps. see dt-bindings/net/ti-dp83869.h for values
>
> + rx-internal-delay-ps:
> + $ref: "#/properties/rx-internal-delay-ps"

This just creates a circular reference which probably blows up.

> + description: Delay is in pico seconds
> + enum: [ 250, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000,
> + 3250, 3500, 3750, 4000 ]
> + default: 2000
> +
> + tx-internal-delay-ps:
> + $ref: "#/properties/tx-internal-delay-ps"
> + description: Delay is in pico seconds
> + enum: [ 250, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000,
> + 3250, 3500, 3750, 4000 ]
> + default: 2000
> +
> required:
> - reg
>
> @@ -80,5 +94,7 @@ examples:
> ti,op-mode = <DP83869_RGMII_COPPER_ETHERNET>;
> ti,max-output-impedance = "true";
> ti,clk-output-sel = <DP83869_CLK_O_SEL_CHN_A_RCLK>;
> + rx-internal-delay-ps = <2000>;
> + tx-internal-delay-ps = <2000>;
> };
> };
> --
> 2.26.2
>