Re: [PATCH v5 0/4] SFH: Add Support for AMD Sensor Fusion Hub

[Andy Shevchenko]

On Fri, May 29, 2020 at 4:42 PM Sandeep Singh <Sandeep.Singh@xxxxxxx> wrote:
>
> From: Sandeep Singh <sandeep.singh@xxxxxxx>
>
> AMD SFH(Sensor Fusion Hub) is HID based driver.SFH FW
> is part of MP2 processor (MP2 which is an ARMÂ Cortex-M4
> core based co-processor to x86) and it runs on MP2 where
> in driver resides on X86.The driver functionalities are
> divided  into three parts:-
>
> 1: amd-mp2-pcie:-       This module will communicate with MP2 FW and
>                         provide that data into DRAM.
> 2: Client driver :-     This part for driver will use dram data and
>                         convert that data into HID format based on
>                         HID reports.
> 3: Transport driver :-  This part of driver will communicate with
>                         HID core. Communication between devices and
>                         HID core is mostly done via HID reports
>
> In terms of architecture it is much more reassembles like
> ISH(Intel Integrated Sensor Hub). However the major difference
> is all the hid reports are generated as part of kernel driver.
> AMD SFH driver taken reference from ISH in terms of
> design and functionalities at fewer location.
>
> AMD sensor fusion Hub is part of a SOC 17h family based platforms.
> The solution is working well on several OEM products.
> AMD SFH uses HID over PCIe bus.
>

I can't believe this is fifth version.
Guys, you have to do much more work on these drivers.

> Sandeep Singh (4):
>   SFH: Add maintainers and documentation for AMD SFH based on HID
>     framework
>   SFH: PCI driver to add support of AMD sensor fusion Hub using HID
>     framework
>   SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH)
>   SFH: Create HID report to Enable support of AMD sensor fusion Hub
>     (SFH)
>
> Changes since v1:
>         -Fix auto build test warnings
>         -Fix warnings captured using smatch
>         -Changes suggested by Dan Carpenter
>
> Links of the review comments for v1:
>         [1] https://patchwork.kernel.org/patch/11325163/
>         [2] https://patchwork.kernel.org/patch/11325167/
>         [3] https://patchwork.kernel.org/patch/11325171/
>         [4] https://patchwork.kernel.org/patch/11325187/
>
>
> Changes since v2:
>         -Debugfs divided into another patch
>         -Fix some cosmetic changes
>         -Fix for review comments
>          Reported and Suggested by:-  Srinivas Pandruvada
>
> Links of the review comments for v2:
>         [1] https://patchwork.kernel.org/patch/11355491/
>         [2] https://patchwork.kernel.org/patch/11355495/
>         [3] https://patchwork.kernel.org/patch/11355499/
>         [4] https://patchwork.kernel.org/patch/11355503/
>
>
> Changes since v3:
>         -removed debugfs suggested by - Benjamin Tissoires
>
> Links of the review comments for v3:
>         [1] https://lkml.org/lkml/2020/2/11/1256
>         [2] https://lkml.org/lkml/2020/2/11/1257
>         [3] https://lkml.org/lkml/2020/2/11/1258
>         [4] https://lkml.org/lkml/2020/2/11/1259
>         [5] https://lkml.org/lkml/2020/2/11/1260
>
>
> Changes since v4:
>         - Rework done based on review comments by - Andy Shevchenko
>         - changes done based on suggested by -Richard Neumann
>
> Links of the review comments for v4:
>         [1] https://lkml.org/lkml/2020/2/26/1360
>         [2] https://lkml.org/lkml/2020/2/26/1361
>         [3] https://lkml.org/lkml/2020/2/26/1362
>         [4] https://lkml.org/lkml/2020/2/26/1363
>         [5] https://lkml.org/lkml/2020/2/27/1
>
>
> Sandeep Singh (4):
>   SFH: Add maintainers and documentation for AMD SFH based      on HID
>     framework
>   SFH: PCI driver to add support of AMD sensor fusion Hub using HID
>     framework
>   SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH
>   SFH: Create HID report to Enable support of AMD sensor fusion Hub
>     (SFH)
>
>  Documentation/hid/amd-sfh-hid.rst                  | 160 +++++
>  MAINTAINERS                                        |   8 +
>  drivers/hid/Kconfig                                |   2 +
>  drivers/hid/Makefile                               |   1 +
>  drivers/hid/amd-sfh-hid/Kconfig                    |  21 +
>  drivers/hid/amd-sfh-hid/Makefile                   |  16 +
>  drivers/hid/amd-sfh-hid/amd_mp2_pcie.c             | 196 +++++++
>  drivers/hid/amd-sfh-hid/amd_mp2_pcie.h             | 137 +++++
>  drivers/hid/amd-sfh-hid/amdsfh-hid-client.c        | 256 ++++++++
>  drivers/hid/amd-sfh-hid/amdsfh-hid.c               | 179 ++++++
>  drivers/hid/amd-sfh-hid/amdsfh-hid.h               |  84 +++
>  .../hid_descriptor/amd_sfh_hid_descriptor.c        | 251 ++++++++
>  .../hid_descriptor/amd_sfh_hid_descriptor.h        | 125 ++++
>  .../hid_descriptor/amd_sfh_hid_report_descriptor.h | 642 +++++++++++++++++++++
>  14 files changed, 2078 insertions(+)
>  create mode 100644 Documentation/hid/amd-sfh-hid.rst
>  create mode 100644 drivers/hid/amd-sfh-hid/Kconfig
>  create mode 100644 drivers/hid/amd-sfh-hid/Makefile
>  create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c
>  create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.h
>  create mode 100644 drivers/hid/amd-sfh-hid/amdsfh-hid-client.c
>  create mode 100644 drivers/hid/amd-sfh-hid/amdsfh-hid.c
>  create mode 100644 drivers/hid/amd-sfh-hid/amdsfh-hid.h
>  create mode 100644 drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_descriptor.c
>  create mode 100644 drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_descriptor.h
>  create mode 100644 drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_descriptor.h
>
> --
> 2.7.4
>


-- 
With Best Regards,
Andy Shevchenko