Re: [PATCH 00/10] iommu/amd: Updates and Cleanups

From: Suravee Suthikulpanit
Date: Fri May 29 2020 - 08:15:28 EST


Joerg,

On 5/27/2020 6:53 PM, Joerg Roedel wrote:
Hi,

here is a collection of patches that clean up a few things
in the AMD IOMMU driver. Foremost, it moves all related
files of the driver into a separate subdirectory.

But the patches also remove usage of dev->archdata.iommu and
clean up dev_data handling and domain allocation.

Patches are runtime-tested, including device-assignment.

Please review.

Regards,

Joerg

Joerg Roedel (10):
iommu/amd: Move AMD IOMMU driver to a subdirectory
iommu/amd: Unexport get_dev_data()
iommu/amd: Let free_pagetable() not rely on domain->pt_root
iommu/amd: Allocate page-table in protection_domain_init()
iommu/amd: Free page-table in protection_domain_free()
iommu/amd: Consolidate domain allocation/freeing
iommu/amd: Remove PD_DMA_OPS_MASK
iommu/amd: Merge private header files
iommu/amd: Store dev_data as device iommu private data
iommu/amd: Remove redundant devid checks

MAINTAINERS | 2 +-
drivers/iommu/Makefile | 6 +-
.../{amd_iommu_proto.h => amd/amd_iommu.h} | 20 +-
drivers/iommu/{ => amd}/amd_iommu_types.h | 0
.../{amd_iommu_debugfs.c => amd/debugfs.c} | 5 +-
.../iommu/{amd_iommu_init.c => amd/init.c} | 6 +-
drivers/iommu/{amd_iommu.c => amd/iommu.c} | 265 ++++++------------
.../iommu/{amd_iommu_v2.c => amd/iommu_v2.c} | 14 +-
.../{amd_iommu_quirks.c => amd/quirks.c} | 0
drivers/iommu/amd_iommu.h | 14 -
10 files changed, 117 insertions(+), 215 deletions(-)
rename drivers/iommu/{amd_iommu_proto.h => amd/amd_iommu.h} (88%)
rename drivers/iommu/{ => amd}/amd_iommu_types.h (100%)
rename drivers/iommu/{amd_iommu_debugfs.c => amd/debugfs.c} (89%)
rename drivers/iommu/{amd_iommu_init.c => amd/init.c} (99%)
rename drivers/iommu/{amd_iommu.c => amd/iommu.c} (95%)
rename drivers/iommu/{amd_iommu_v2.c => amd/iommu_v2.c} (98%)
rename drivers/iommu/{amd_iommu_quirks.c => amd/quirks.c} (100%)
delete mode 100644 drivers/iommu/amd_iommu.h


Thank you for cleaning up.

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>