Re: [PATCH 09/12] xfs: flag files as supporting buffered async reads

From: Jens Axboe
Date: Thu May 28 2020 - 15:23:40 EST


On 5/28/20 11:53 AM, Darrick J. Wong wrote:
> On Tue, May 26, 2020 at 01:51:20PM -0600, Jens Axboe wrote:
>> XFS uses generic_file_read_iter(), which already supports this.
>>
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>
> Er... I guess that looks ok? Assuming you've done enough qa on
> io_uring to be able to tell if this breaks anything, since touching the
> mm always feels murky to me:
>

The mm bits should be fine, haven't seen anything odd in testing.
And it's not like the mm changes are super complicated, I think
they turned out pretty clean and straight forward.

> Acked-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Thanks!

--
Jens Axboe