Re: [PATCH] mm: memcontrol: fix an unused-function warning

From: Johannes Weiner
Date: Thu May 28 2020 - 13:16:17 EST


On Thu, May 28, 2020 at 11:56:26AM +0200, Arnd Bergmann wrote:
> On NOMMU kernels without CONFIG_MEMCG_KMEM, we now get a harmless
> warning about an unused function:
>
> mm/memcontrol.c:2595:13: error: unused function 'cancel_charge' [-Werror,-Wunused-function]
>
> Hide this function in a matching #ifdef.
>
> Fixes: 5bd144bf764c ("mm: memcontrol: drop unused try/commit/cancel charge API")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Thanks Arnd!