Re: [RFC][PATCH 1/3] objtool: Rename rela to reloc

From: Matt Helsley
Date: Thu May 28 2020 - 12:00:04 EST


On Thu, May 28, 2020 at 09:04:44AM -0500, Josh Poimboeuf wrote:
> On Wed, May 27, 2020 at 09:42:31AM -0700, Matt Helsley wrote:
> > Before supporting additional relocation types rename the relevant
> > types and functions from "rela" to "reloc". This work can largely
> > be done with the following regex:
> >
> > Notable exceptions include gelf_* library calls and
> > standard/expected section names which still use "rela" because
> > they encode the type of relocation expected. Also, keep "rela"
> > in the struct because it encodes a specify type of relocation
>
> Missing regex?

I briefly looked into it and went with a manual process instead. I can
try and work backwards to reproduce the patch with a regex though.

> BTW it would be really nice if the regex were exact if possible, for
> stable backporting reasons.

Agreed. I'll see what I can come up with and put it and any necessary
details in the commit message for the next posting.

Cheers,
-Matt Helsley