Re: inux-next: build failure after merge of the drm-msm tree

From: Valdis KlÄtnieks
Date: Wed May 27 2020 - 22:33:32 EST


On Tue, 26 May 2020 21:16:18 -0700, Nathan Chancellor said:

> Additionally, I see a failure with clang due to the use of Bps_to_icc,
> which does a straight division by 1000, which is treated as an integer
> literal, with avg_bw as the dividend, which is a u64.
>
> Below is the "hack" in my tree.

Also needed with gcc 8.3 for arm allmodconfig.

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> index 85c2a4190840..5ea725d8da6c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> @@ -250,7 +250,7 @@ static int _dpu_core_perf_crtc_update_bus(struct dpu_kms *kms,
>
> for (i = 0; i < kms->num_paths; i++)
> icc_set_bw(kms->path[i],
> - Bps_to_icc(avg_bw), (perf.max_per_pipe_ib));
> + div_u64(avg_bw, 1000), (perf.max_per_pipe_ib));
>
> return ret;
> }
>

Attachment: pgpZBEaGB9SXn.pgp
Description: PGP signature