Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

From: David Miller
Date: Wed May 27 2020 - 14:25:19 EST


From: Bartosz Golaszewski <brgl@xxxxxxxx>
Date: Wed, 27 May 2020 11:24:04 +0200

> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> The dma_addr field in desc_data must not be overwritten until after the
> new skb is mapped. Currently we do replace it with uninitialized value
> in error path. This change fixes it by moving the assignment before the
> label to which we jump after mapping or allocation errors.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

Applied, please use "[PATCH net-next]" to clearly indicate the target
GIT tree next time.

Thank you.