Re: [PATCH v10 3/6] dt-bindings: clock: Add X1830 bindings.

[Zhou Yanjie]

Hi Stephen,

I'm very sorry, forgive my carelessness, communication with Paul 
Cercueil made me realize that the modification of 
"CLK_OF_DECLARE_DRIVER" mentioned in comments of [7/7] has never really 
existed in the patch, v12 has fixed this problem, and split the patch 
about bindings according to your requirements, it may be a good idea to 
retake [4/7] and [7/7] of v12.

Thanks and best regards!

å 2020/5/27 äå4:12, Stephen Boyd åé:
> Quoting åçæ (Zhou Yanjie) (2020-05-26 07:40:41)
> > Add the clock bindings for the X1830 Soc from Ingenic.
> >
> > Signed-off-by: \u5468\u7430\u6770 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> >
> > Notes:
> >      v2->v3:
> >      Adjust order from [3/5] in v2 to [4/5] in v3.
> >      
> >      v3->v4:
> >      Adjust order from [4/5] in v3 to [3/4] in v4.
> >      
> >      v4->v5:
> >      Rebase on top of kernel 5.6-rc1.
> >      
> >      v5->v6:
> >      Add missing part of X1830's CGU.
> >      
> >      v6->v7:
> >      No change.
> >      
> >      v7->v8:
> >      Rebase on top of linux-next.
> >      
> >      v8->v9:
> >      No change.
> >      
> >      v9->v10:
> >      Add missing "X1830_CLK_TCU".
> >
> >   .../devicetree/bindings/clock/ingenic,cgu.yaml     |  2 +
> >   include/dt-bindings/clock/x1830-cgu.h              | 55 ++++++++++++++++++++++
> >   2 files changed, 57 insertions(+)
> >   create mode 100644 include/dt-bindings/clock/x1830-cgu.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml b/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
> This file is in Rob's DT tree staged for the next release, not in the
> clk tree. Can you split this patch into two, one for the compatible
> update and another for the header file update and send again? Then Rob
> can pick up the yaml file change and I can pick up the header file
> change.
>
> > index 0281cd1d7e1b..a952d5811823 100644
> > --- a/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
> > +++ b/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
> > @@ -25,6 +25,7 @@ select:
> >             - ingenic,jz4770-cgu
> >             - ingenic,jz4780-cgu
> >             - ingenic,x1000-cgu
> > +          - ingenic,x1830-cgu
> >     required:
> >       - compatible
> >   
> > @@ -51,6 +52,7 @@ properties:
> >           - ingenic,jz4770-cgu
> >           - ingenic,jz4780-cgu
> >           - ingenic,x1000-cgu
> > +        - ingenic,x1830-cgu
> >         - const: simple-mfd
> >       minItems: 1