Re: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()

[Greg KH]

On Wed, May 27, 2020 at 07:50:56AM +0000, nobuhiro1.iwamatsu@xxxxxxxxxxxxx wrote:
> Hi,
> 
> > -----Original Message-----
> > From: stable-owner@xxxxxxxxxxxxxxx [mailto:stable-owner@xxxxxxxxxxxxxxx] On Behalf Of Greg Kroah-Hartman
> > Sent: Wednesday, May 27, 2020 3:53 AM
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx; Peter Zijlstra (Intel)
> > <peterz@xxxxxxxxxxxxx>; Lauro Ramos Venancio <lvenanci@xxxxxxxxxx>; Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>;
> > Mike Galbraith <efault@xxxxxx>; Rik van Riel <riel@xxxxxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>;
> > lwang@xxxxxxxxxx; Ingo Molnar <mingo@xxxxxxxxxx>; Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>; Sasha Levin
> > <sashal@xxxxxxxxxx>
> > Subject: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()	
> > 
> > From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > 
> > [ Upstream commit c743f0a5c50f2fcbc628526279cfa24f3dabe182 ]
> > 
> > More users for for_each_cpu_wrap() have appeared. Promote the construct
> > to generic cpumask interface.
> > 
> > The implementation is slightly modified to reduce arguments.
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > Cc: Lauro Ramos Venancio <lvenanci@xxxxxxxxxx>
> > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Mike Galbraith <efault@xxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Rik van Riel <riel@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: lwang@xxxxxxxxxx
> > Link: http://lkml.kernel.org/r/20170414122005.o35me2h5nowqkxbv@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > [dj: include only what's added to the cpumask interface, 4.4 doesn't
> >      have them in the scheduler]
> > Signed-off-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  include/linux/cpumask.h | 17 +++++++++++++++++
> >  lib/cpumask.c           | 32 ++++++++++++++++++++++++++++++++
> >  2 files changed, 49 insertions(+)
> 
> This commit also needs the following commits:
> 
> commit d207af2eab3f8668b95ad02b21930481c42806fd
> Author: Michael Kelley <mhkelley@xxxxxxxxxxx>
> Date:   Wed Feb 14 02:54:03 2018 +0000
> 
>     cpumask: Make for_each_cpu_wrap() available on UP as well
>     
>     for_each_cpu_wrap() was originally added in the #else half of a
>     large "#if NR_CPUS == 1" statement, but was omitted in the #if
>     half.  This patch adds the missing #if half to prevent compile
>     errors when NR_CPUS is 1.
>     
>     Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>     Signed-off-by: Michael Kelley <mhkelley@xxxxxxxxxxx>
>     Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>     Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>     Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     Cc: kys@xxxxxxxxxxxxx
>     Cc: martin.petersen@xxxxxxxxxx
>     Cc: mikelley@xxxxxxxxxxxxx
>     Fixes: c743f0a5c50f ("sched/fair, cpumask: Export for_each_cpu_wrap()")
>     Link: http://lkml.kernel.org/r/SN6PR1901MB2045F087F59450507D4FCC17CBF50@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>     Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> 
> Please apply this commit.

Good catch, now queued up, thanks.

greg k-h