Re: [PATCH v8 2/3] Add the bindings for the bq25150 and bq25155 500mA charging ICs from Texas Instruments.

From: Rob Herring
Date: Tue May 26 2020 - 16:53:16 EST


On Wed, May 20, 2020 at 07:20:26AM -0500, Dan Murphy wrote:
> From: Ricardo Rivera-Matos <r-rivera-matos@xxxxxx>
>
> The BQ2515X family of devices are highly integrated battery management
> ICs that integrate the most common functions for wearable devices
> namely a charger, an output voltage rail, ADC for battery and system
> monitoring, and a push-button controller.
>
> Datasheets:
> http://www.ti.com/lit/ds/symlink/bq25150.pdf
> http://www.ti.com/lit/ds/symlink/bq25155.pdf
>
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@xxxxxx>
> ---
> .../bindings/power/supply/bq2515x.yaml | 106 ++++++++++++++++++
> 1 file changed, 106 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml
> new file mode 100644
> index 000000000000..83487957fc8c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq2515x.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: TI bq2515x 500-mA Linear charger family
> +
> +maintainers:
> + - Dan Murphy <dmurphy@xxxxxx>
> + - Ricardo Rivera-Matos <r-rivera-matos@xxxxxx>
> +
> +description: |
> + The BQ2515x family is a highly integrated battery charge management IC that
> + integrates the most common functions for wearable devices, namely a charger,
> + an output voltage rail, ADC for battery and system monitoring, and
> + push-button controller.
> +
> + Specifications about the charger can be found at:
> + http://www.ti.com/lit/ds/symlink/bq25150.pdf
> + http://www.ti.com/lit/ds/symlink/bq25155.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - ti,bq25150
> + - ti,bq25155
> +
> + reg:
> + maxItems: 1
> + description: I2C address of the charger.
> +
> + ac-detect-gpios:
> + description: |
> + GPIO used for connecting the bq2515x device PG (AC Detect)
> + pin. This pin should be used if possible as this is the
> + recommended way to obtain the charger's input PG state.
> + If this pin is not specified a software-based approach for PG
> + detection is used.

How many? (maxItems: 1)

Same for the rest of the GPIOs.

> +
> + reset-gpios:
> + description: |
> + GPIO used for hardware reset.
> +
> + low-power-gpios:
> + description: |
> + GPIO used for low power mode of IC.

powerdown-gpios is the somewhat standard name for this.

> +
> + charge-enable-gpios:
> + description: |
> + GPIO used to turn on and off charging.
> +

> + constant-charge-current-max-microamp:
> + description: |
> + Maximum charging current in micro Amps.
> + minimum: 50000
> + maximum: 600000
> +
> + precharge-current-max-microamp:
> + description: |
> + Maximum precharging current in micro Amps.
> + minimum: 1250
> + maximum: 77500
> +
> + input-current-limit-microamp:
> + description: |
> + Maximum input current in micro Amps.
> + minimum: 50000
> + maximum: 500000
> +
> + constant-charge-voltage-max-microvolt:
> + description: |
> + Maximum charging voltage in micro volts.
> + minimum: 3600000
> + maximum: 4600000

Other than input-current-limit-microamp, none of these should be part of
this schema as they apply to the battery node. There's not really a way
for us to express something like this.

> +
> +required:
> + - compatible
> + - reg

Add:

additionalProperties: false

> +
> +examples:
> + - |
> + bat: battery {
> + compatible = "simple-battery";
> + constant-charge-current-max-microamp = <50000>;
> + precharge-current-microamp = <2500>;
> + constant-charge-voltage-max-microvolt = <4000000>;
> + };
> + #include <dt-bindings/gpio/gpio.h>
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bq25150: charger@6b {
> + compatible = "ti,bq25150";
> + reg = <0x6b>;
> + monitored-battery = <&bat>;

Not documented.

> + input-current-limit-microamp = <100000>;
> +
> + ac-detect-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> + low-power-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
> + charge-enable-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>;
> + };
> + };
> --
> 2.26.2
>