Re: [PATCH v3 2/3] extcon: max14577: Add proper dt-compatible strings

From: Chanwoo Choi
Date: Sun May 24 2020 - 23:25:06 EST


Hi Marek,

On 5/22/20 7:24 PM, Marek Szyprowski wrote:
> Add device tree compatible strings and create proper modalias structures
> to let this driver load automatically if compiled as module, because
> max14577 MFD driver creates MFD cells with such compatible strings.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
> v3:
> - sorted of_max14577_muic_dt_match
> v2:
> - added .of_match_table pointer
> ---
> drivers/extcon/extcon-max14577.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 32f663436e6e..03af678ddeba 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
> };
> MODULE_DEVICE_TABLE(platform, max14577_muic_id);
>
> +static const struct of_device_id of_max14577_muic_dt_match[] = {
> + { .compatible = "maxim,max14577-muic",
> + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
> + { .compatible = "maxim,max77836-muic",
> + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, of_max14577_muic_dt_match);
> +
> static struct platform_driver max14577_muic_driver = {
> .driver = {
> .name = "max14577-muic",
> + .of_match_table = of_max14577_muic_dt_match,
> },
> .probe = max14577_muic_probe,
> .remove = max14577_muic_remove,
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics