Re: Re: Re: Re: [PATCH] spi: tegra20-slink: Fix runtime PM imbalance on error

[dinghao . liu]

> On Sat, May 23, 2020 at 2:32 PM <dinghao.liu@xxxxxxxxxx> wrote:
> >
> > > On Fri, May 22, 2020 at 6:20 PM Andy Shevchenko
> > > <andy.shevchenko@xxxxxxxxx> wrote:
> > > > On Fri, May 22, 2020 at 10:46 AM <dinghao.liu@xxxxxxxxxx> wrote:
> 
> ...
> 
> > I also checked many other implementation of probe in drivers.
> > It seems that using pm_runtime_put() is ok.
> 
> In *error path* or normal path?
> 

Error path (e.g., sysc_probe, exynos_trng_probe, 
map_rng_probe, ti_eqep_probe).

> > If I misunderstood
> > your opinion, please point it out, thanks.
> 
> Bottom line is (for the *error path* case):
> pm_runtime_put_noidle() has no side effects
> pm_runtime_put() (potentially) might have side effects.
> 
> You should choose one which is clearer about what it does.
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Agree, for this bug using _noidle() is clearer. I will 
send a new path to fix this.

Regards,
Dinghao