Re: [PATCH -net-next] net: psample: depends on INET

From: Randy Dunlap
Date: Fri May 22 2020 - 15:48:57 EST


On 5/22/20 12:17 PM, Cong Wang wrote:
> On Fri, May 22, 2020 at 12:03 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>> Fix psample build error when CONFIG_INET is not set/enabled.
>> PSAMPLE should depend on INET instead of NET since
>> ip_tunnel_info_opts() is only present for CONFIG_INET.
>>
>> ../net/psample/psample.c: In function â__psample_ip_tun_to_nlattrâ:
>> ../net/psample/psample.c:216:25: error: implicit declaration of function âip_tunnel_info_optsâ; did you mean âip_tunnel_info_opts_setâ? [-Werror=implicit-function-declaration]
>
> Or just make this tunnel support optional. psample does not
> require it to function correctly.

Sure, I thought of that, but it's not clear to me which bits of it
to make optional, so I'll leave it for its maintainer to handle.

thanks.
--
~Randy