Re: [PATCH v3 2/2] arm64: dts: Add ds26522 node to dts to ls1043ardb

From: Li Yang
Date: Fri May 22 2020 - 15:39:13 EST


On Tue, May 19, 2020 at 11:08 PM Qiang Zhao <qiang.zhao@xxxxxxx> wrote:
>
> From: Zhao Qiang <qiang.zhao@xxxxxxx>

Maybe remove the duplicated dts in the title?

>
> Add ds26522 node to fsl-ls1043a-rdb.dts
>
> Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx>
> ---
> v3:
> - use "arm64: dts:" format for subject
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 44d9343..1cb265f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -94,6 +94,22 @@
> reg = <0>;
> spi-max-frequency = <1000000>; /* input clock */
> };
> +
> + slic@2 {

If this is a plugin card for the board, will this cause any problem
when the card is not plugged in?

> + compatible = "maxim,ds26522";
> + reg = <2>;
> + spi-max-frequency = <2000000>;
> + fsl,spi-cs-sck-delay = <100>;
> + fsl,spi-sck-cs-delay = <50>;
> + };
> +
> + slic@3 {
> + compatible = "maxim,ds26522";
> + reg = <3>;
> + spi-max-frequency = <2000000>;
> + fsl,spi-cs-sck-delay = <100>;
> + fsl,spi-sck-cs-delay = <50>;
> + };
> };
>
> &duart0 {
> --
> 2.7.4
>