Re: [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response()

From: Markus Elfring
Date: Fri May 22 2020 - 02:31:20 EST


> In function rxkad_verify_response(), pointer "ticket" is not released,
> when function rxkad_decrypt_ticket() returns an error, causing a
> memory leak bug.

I suggest to improve also this change description.
How do you think about a wording variant like the following?

A ticket was not released after a call of the function âplatform_get_irqâ failed.
Thus replace the jump target âtemporary_error_free_respâ
by âtemporary_error_free_ticketâ.


Regards,
Markus