Re: [PATCH] [v2] usb: musb: Fix runtime PM imbalance on error

From: Greg Kroah-Hartman
Date: Fri May 22 2020 - 01:12:42 EST


On Fri, May 22, 2020 at 10:59:02AM +0800, Dinghao Liu wrote:
> When copy_from_user() returns an error code, there
> is a runtime PM usage counter imbalance.
>
> Fix this by moving copy_from_user() to the beginning
> of this function.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
> drivers/usb/musb/musb_debugfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

What changed from v1? Always show that below the --- line as the
documentation says to.

thanks,

greg k-h