Re: [PATCH] net: sgi: ioc3-eth: Fix return value check in ioc3eth_probe()

From: David Miller
Date: Thu May 21 2020 - 20:27:14 EST


From: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 20 May 2020 17:55:32 +0800

> In the function devm_platform_ioremap_resource(), if get resource
> failed, the return value is ERR_PTR() not NULL. Thus it must be
> replaced by IS_ERR(), or else it may result in crashes if a critical
> error path is encountered.
>
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> Signed-off-by: Zhang Shengju <zhangshengju@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>

Applied, thanks.