Re: [PATCH net-next v3 0/2] provide KAPI for SQI

From: David Miller
Date: Thu May 21 2020 - 20:18:19 EST


From: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
Date: Wed, 20 May 2020 08:29:13 +0200

> This patches are extending ethtool netlink interface to export Signal
> Quality Index (SQI). SQI provided by 100Base-T1 PHYs and can be used for
> cable diagnostic. Compared to a typical cable tests, this value can be
> only used after link is established.
>
> changes v3:
> - rename __ethtool_get_sqi* to linkstate_get_sqi*. And move this
> functions to the net/ethtool/linkstate.c
> - protect linkstate_get_sqi* with locking
>
> changes v2:
> - use u32 instead of u8 for SQI
> - add SQI_MAX field and callbacks
> - some style fixes in the rst.
> - do not convert index to shifted index.

Series applied, thank you.