Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

From: David Miller
Date: Thu May 21 2020 - 20:05:41 EST


From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Date: Tue, 19 May 2020 23:44:16 +0530

> Once the traversal of the list is completed with list_for_each_entry(),
> the iterator (node) will point to an invalid object. So passing this to
> qrtr_local_enqueue() which is outside of the iterator block is erroneous
> eventhough the object is not used.
>
> So fix this by passing NULL to qrtr_local_enqueue().
>
> Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Reported-by: Julia Lawall <julia.lawall@xxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Applied and queued up for -stable, thanks.