Re: [PATCH 11/23] bpf: factor out a bpf_trace_copy_string helper

From: Andrii Nakryiko
Date: Thu May 21 2020 - 18:10:47 EST


On Thu, May 21, 2020 at 8:25 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Split out a helper to do the fault free access to the string pointer
> to get it out of a crazy indentation level.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

> kernel/trace/bpf_trace.c | 42 +++++++++++++++++++++++-----------------
> 1 file changed, 24 insertions(+), 18 deletions(-)
>

[...]