Re: [RFC PATCH 2/2] init: Allow multi-line output of kernel command line

From: Joe Perches
Date: Thu May 21 2020 - 12:09:46 EST


On Thu, 2020-05-21 at 11:59 -0400, Arvind Sankar wrote:
> On Tue, May 19, 2020 at 12:42:35PM -0700, Joe Perches wrote:
> > ARM may have its longest possible command line larger than the longest
> > possible printk.
[]
> I might be missing something, but this seems broken:

probably, note the "untested" bit.

> (1) If there is a ' ', the memchr will set pos to the ' ' the first time
> through the inner loop, and then go into an infinite loop? You want
> memrchr here but the kernel doesn't seem to have one.

Right. I did look and didn't find one and didn't
want to add it just for this use.