Re: [PATCH v5 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER

[Michel Lespinasse]

On Mon, May 18, 2020 at 12:45:06PM +0200, Vlastimil Babka wrote:
> On 4/22/20 2:14 AM, Michel Lespinasse wrote:
> > Define a new initializer for the mmap locking api.
> > Initially this just evaluates to __RWSEM_INITIALIZER as the API
> > is defined as wrappers around rwsem.
> > 
> > Signed-off-by: Michel Lespinasse <walken@xxxxxxxxxx>
> 
> 
> Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx>
> 
> 
> Nit below.
> 
> > +#define MMAP_LOCK_INITIALIZER(name) \
> > +	.mmap_sem = __RWSEM_INITIALIZER(name.mmap_sem),
> 
> "(name).mmap_sem" is safer in a macro?

Thanks, applied in next version.

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.