Re: [PATCH v5 02/10] MMU notifier: use the new mmap locking API

[Laurent Dufour]

Le 22/04/2020 Ã 02:14, Michel Lespinasse a ÃcritÂ:
> This use is converted manually ahead of the next patch in the series,
> as it requires including a new header which the automated conversion
> would miss.
>
> Signed-off-by: Michel Lespinasse <walken@xxxxxxxxxx>
> Reviewed-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>
> Reviewed-by: Davidlohr Bueso <dbueso@xxxxxxx>

Reviewed-by: Laurent Dufour <ldufour@xxxxxxxxxxxxx>

> ---
>   include/linux/mmu_notifier.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index 736f6918335e..2f462710a1a4 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -5,6 +5,7 @@
>   #include <linux/list.h>
>   #include <linux/spinlock.h>
>   #include <linux/mm_types.h>
> +#include <linux/mmap_lock.h>
>   #include <linux/srcu.h>
>   #include <linux/interval_tree.h>
>   
> @@ -277,9 +278,9 @@ mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
>   {
>   	struct mmu_notifier *ret;
>   
> -	down_write(&mm->mmap_sem);
> +	mmap_write_lock(mm);
>   	ret = mmu_notifier_get_locked(ops, mm);
> -	up_write(&mm->mmap_sem);
> +	mmap_write_unlock(mm);
>   	return ret;
>   }
>   void mmu_notifier_put(struct mmu_notifier *subscription);