Re: [PATCH net-next] hinic: add support to set and get pause param

[luobin (L)]

Will fix. Thanks.

On 2020/5/17 4:25, David Miller wrote:
> From: Luo bin <luobin9@xxxxxxxxxx>
> Date: Sat, 16 May 2020 02:00:30 +0000
>
> > add support to set pause param with ethtool -A and get pause
> > param with ethtool -a. Also remove set_link_ksettings ops for VF.
> >
> > Signed-off-by: Luo bin <luobin9@xxxxxxxxxx>
> Why are you using a semaphore and not a plain mutex.
>
> Semaphores should be used as an absolute last resort, and only
> after trying vigorously to use other locking primitives.
> .