Re: [PATCH v2 7/9] KVM: SVM: keep DR6 synchronized with vcpu->arch.dr6

From: Paolo Bonzini
Date: Thu May 07 2020 - 18:21:24 EST


On 07/05/20 20:22, Peter Xu wrote:
>> - svm->vmcb->save.dr6 = nested_vmcb->save.dr6;
>> + svm->vcpu.arch.dr6 = nested_vmcb->save.dr6;
> The rest looks very sane to me, but here I failed to figure out how arch.dr6
> finally applied to save.dr6. I saw it is applied in svm_vcpu_run() in the next
> patch, but if that's the case then iiuc this commit may break bisection. Thanks,

You're right, this needs a call to kvm_update_dr6 (which would go away
on the next patch).

Paolo