Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()

From: Kalle Valo
Date: Thu May 07 2020 - 13:47:21 EST


Markus Elfring <Markus.Elfring@xxxxxx> writes:

> â
>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> â
>> @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev)
>> out_unmap:
>> iounmap(wcn->ccu_base);
>> iounmap(wcn->dxe_base);
>> +out_channel:
>> + rpmsg_destroy_ept(wcn->smd_channel);
>> out_wq:
>> ieee80211_free_hw(hw);
>> out_err:
>
> How do you think about to use the label âout_destroy_eptâ?

Yeah, that's better. I'll change it in the pending branch before I
commit.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches