Re: [PATCH v1] Add support for MediaTek regulator vibrator driver

From: Pavel Machek
Date: Thu May 07 2020 - 13:45:25 EST


Hi!

> This patchset add regulator vibrator driver for MTK Soc. The driver
> controls vibrator through regulator's enable and disable.

We'd prefer not to have vibrators in led subsystem.

>
> Xing Zhang (3):
> dt-bindings: add regulator vibrator documentation
> arm64: mediatek: Add regulator vibrator support
> Vibrator: Add regulator vibrator driver
>
> .../bindings/leds/regulator-vibrator.txt | 39 ++
> arch/arm64/configs/defconfig | 1 +
> drivers/leds/Kconfig | 10 +
> drivers/leds/Makefile | 1 +
> drivers/leds/regulator-vibrator.c | 450 ++++++++++++++++++

OTOH, connecting LED to regulator might make some sense. I can take the driver with
vibrator functionality stripped, provided it is named the usual way...

Best regards,
Pavel