Re: [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex

[Masahiro Yamada]

On Thu, May 7, 2020 at 8:43 PM Maninder Singh <maninder1.s@xxxxxxxxxxx> wrote:
>
> Hi Masahiro,
>
> Thanks for review.
> We will integrate your review comements and send v2.
>
> >>
>
> >> so making regex $re for ARM similar to aarch64
> >>
> >> Signed-off-by: Vaneet Narang <v.narang@xxxxxxxxxxx>
> >> Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> >
> >
> >This looks good to me, and it is a bug fix.
> >
> >Just a question about the SOB.
> >
> >
> >Maninder Singh is the author and also the submitter, right?
> >
> >What does "Signed-off-by: Vaneet Narang <v.narang@xxxxxxxxxxx>" mean?
> >
> >Co-developed-by or something else?
>
> Yes All 4 patches are co-developed by Vaneet and me.
> we were checking stack usage for arm and AARCH64 and found
> some changes in scrips which can help others also.
>

OK. Then,

Co-developed-by: Vaneet Narang <v.narang@xxxxxxxxxxx>

is the correct tag.


Signed-off-by is added when the patch is forwarded by
somebody else. This is not the case.







-- 
Best Regards
Masahiro Yamada