Re: [PATCH net-next] net: bridge: return false in br_mrp_enabled()

From: Nikolay Aleksandrov
Date: Wed May 06 2020 - 05:47:43 EST


On 06/05/2020 09:16, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
> 'br_mrp_enabled' with return type bool
>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> ---
> net/bridge/br_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index c35647cb138a..78d3a951180d 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1331,7 +1331,7 @@ static inline int br_mrp_process(struct net_bridge_port *p, struct sk_buff *skb)
>
> static inline bool br_mrp_enabled(struct net_bridge *br)
> {
> - return 0;
> + return false;
> }
>
> static inline void br_mrp_port_del(struct net_bridge *br,
>
Fixes: 6536993371fab ("bridge: mrp: Integrate MRP into the bridge")
Acked-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>