Re: [PATCH bpf-next 0/4] RV64 BPF JIT Optimizations

From: Daniel Borkmann
Date: Wed May 06 2020 - 04:08:35 EST


On 5/6/20 9:08 AM, BjÃrn TÃpel wrote:
On Wed, 6 May 2020 at 02:03, Luke Nelson <lukenels@xxxxxxxxxxxxxxxxx> wrote:

This patch series introduces a set of optimizations to the BPF JIT
on RV64. The optimizations are related to the verifier zero-extension
optimization and BPF_JMP BPF_K.

We tested the optimizations on a QEMU riscv64 virt machine, using
lib/test_bpf and test_verifier, and formally verified their correctness
using Serval.


Luke and Xi,

Thanks a lot for working on this! Very nice series!

For the series:
Reviewed-by: BjÃrn TÃpel <bjorn.topel@xxxxxxxxx>
Acked-by: BjÃrn TÃpel <bjorn.topel@xxxxxxxxx>

Luke Nelson (4):
bpf, riscv: Enable missing verifier_zext optimizations on RV64
bpf, riscv: Optimize FROM_LE using verifier_zext on RV64
bpf, riscv: Optimize BPF_JMP BPF_K when imm == 0 on RV64
bpf, riscv: Optimize BPF_JSET BPF_K using andi on RV64

arch/riscv/net/bpf_jit_comp64.c | 64 ++++++++++++++++++++++-----------
1 file changed, 44 insertions(+), 20 deletions(-)

Cc: Xi Wang <xi.wang@xxxxxxxxx>

Applied, thanks everyone!