Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

[Bhupesh Sharma]

Hi David,

On Wed, May 6, 2020 at 2:54 AM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Bhupesh Sharma <bhsharma@xxxxxxxxxx>
> Date: Wed,  6 May 2020 00:34:40 +0530
>
> > -#define NUM_RX_BDS_DEF               ((u16)BIT(10) - 1)
> > +#define NUM_RX_BDS_DEF               ((is_kdump_kernel()) ? ((u16)BIT(6) - 1) : ((u16)BIT(10) - 1))
>
> These parenthesis are very excessive and unnecessary.  At the
> very least remove the parenthesis around is_kdump_kernel().

Thanks a lot for the review.
Sure, will fix this in the v2.

Regards,
Bhupesh