Re: [PATCH v2] stacktrace: cleanup inconsistent variable type

From: Walter Wu
Date: Tue May 05 2020 - 22:18:32 EST


On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote:
> On 4/20/20 6:35 PM, Walter Wu wrote:
> > Modify the variable type of 'skip' member of struct stack_trace.
> > In theory, the 'skip' variable type should be unsigned int.
> > There are two reasons:
> > - The 'skip' only has two situation, 1)Positive value, 2)Zero
> > - The 'skip' of struct stack_trace has inconsistent type with struct
> > stack_trace_data, it makes a bit confusion in the relationship between
> > struct stack_trace and stack_trace_data.
>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

Hi Andrew,

Would you know why not to be picked up this patch yet?
Do I miss somethings?


Thank you for your help.

Walter